feat: add rattler_glob as a crate #2012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Jan 28, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces a new crate called rattler_glob that provides glob pattern matching with hash computation and modification time tracking capabilities. The crate was originally developed in pixi and has been refactored and adapted for use in the rattler ecosystem, specifically for rattler_build.
Changes:
- Adds
rattler_globcrate with comprehensive glob matching using gitignore-style patterns - Implements hash computation over matched files with line-ending normalization
- Provides modification time tracking and caching for glob-based operations
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rattler_glob/Cargo.toml | New crate manifest with dependencies on ignore, rattler_digest, tokio, and other workspace crates |
| crates/rattler_glob/src/lib.rs | Main library entry point with comprehensive module documentation |
| crates/rattler_glob/src/glob_set/mod.rs | Core glob matching implementation with rebasing support |
| crates/rattler_glob/src/glob_set/walk_root.rs | Pattern rebasing logic for handling relative paths and computing effective walk roots |
| crates/rattler_glob/src/glob_set/walk.rs | Directory walking implementation with hidden folder handling |
| crates/rattler_glob/src/glob_hash.rs | Hash computation over matched files with line-ending normalization |
| crates/rattler_glob/src/glob_hash_cache.rs | Async caching layer for glob hash computations |
| crates/rattler_glob/src/glob_mtime.rs | Modification time tracking for matched files |
| tests/data/satisfiability/source-dependency/pixi.toml | Test data file for glob hash computation tests |
| tests/data/satisfiability/source-dependency/pixi.lock | Test data file for glob hash computation tests |
| crates/rattler_glob/src/snapshots/*.snap | Insta snapshot files for testing glob hash results |
| Cargo.lock | Updated with new ignore dependency and rattler_glob entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
baszalmstra
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new crate called
rattler_globthat allows globbing and hash calculations for sets of globs. We have been using this in pixi but are thinking of also using it inrattler_build. So I copied the crate and refactored it a bit with help from Claude to clean it up. I did not really change the API.I think it's okay to go, but I put it in draft so we can take a good look at it.